Skip to content

fix(tasks): center PR badges #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arnestrickmann merged 3 commits into from
Jul 7, 2026
+7 −5
Merged

fix(tasks): center PR badges #2779

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aeea4f2
fix(tasks): center PR badges
janburzinski Jul 7, 2026
ca66239
fix(tasks): align PR badge text
janburzinski Jul 7, 2026
48f0f39
fix(tasks): match PR number typography
janburzinski Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions apps/emdash-desktop/src/renderer/lib/components/pr-badge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,20 @@ export function PrBadge({ variant = 'default', pr, className, hoverDelay }: PrBa
return (
<div
className={cn(
'flex items-center gap-2 px-1.5 py-0.5 rounded-md bg-background-2 max-w-52',
'flex h-5 max-w-52 items-center gap-1.5 rounded-md bg-background-2 px-1.5 leading-none',
className
)}
>
<StatusIcon className="size-3" pr={pr} disableTooltip />
<PrNumberBadge number={getPrNumber(pr) ?? 0} className="text-[10px]" />
<span className="truncate text-xs text-foreground-muted">{pr.title}</span>
<span className="shrink-0 text-xs leading-none text-foreground-muted">
#{getPrNumber(pr) ?? 0}
</span>
Comment thread
janburzinski marked this conversation as resolved.
Outdated
<span className="truncate text-xs leading-none text-foreground-muted">{pr.title}</span>
</div>
);
case 'compact':
return (
<div className={cn('px-1 flex items-center justify-center', className)}>
<div className={cn('flex h-5 items-center justify-center px-1 leading-none', className)}>
<StatusIcon className="size-3" pr={pr} disableTooltip />
</div>
);
Expand All @@ -44,7 +46,7 @@ export function PrBadge({ variant = 'default', pr, className, hoverDelay }: PrBa

return (
<Popover>
<PopoverTrigger openOnHover delay={hoverDelay}>
<PopoverTrigger className="flex items-center leading-none" openOnHover delay={hoverDelay}>
{renderBadge()}
</PopoverTrigger>
<PopoverContent className="w-auto max-w-sm min-w-72">
Expand Down
Loading