Skip to content

fix(tasks): center PR badges#2779

Merged
arnestrickmann merged 3 commits into
mainfrom
jan/eng-1773-branch-name-badges-are-not-centered-on-tasks-overview-page
Jul 7, 2026
Merged

fix(tasks): center PR badges#2779
arnestrickmann merged 3 commits into
mainfrom
jan/eng-1773-branch-name-badges-are-not-centered-on-tasks-overview-page

Conversation

@janburzinski

@janburzinski janburzinski commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

summary

  • align PR badge contents with a fixed badge height and leading-none text
  • replace the nested number badge in the default PR badge with inline text for better vertical alignment

screenshot

before:
Screenshot 2026-07-07 at 11 28 32
after:
Screenshot 2026-07-07 at 11 27 58

@greptile-apps

greptile-apps Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adjusts the PR badge layout for better vertical alignment. The main changes are:

  • Fixed-height styling for default and compact PR badges.
  • Inline PR number text in the default badge trigger.
  • Leading and flex alignment classes on the popover trigger.

Confidence Score: 5/5

This looks safe to merge after a small visual cleanup.

  • No blocking issues found in the changed code.
  • The only issue found is a typography mismatch for PR numbers in the badge trigger.

apps/emdash-desktop/src/renderer/lib/components/pr-badge.tsx

Important Files Changed

Filename Overview
apps/emdash-desktop/src/renderer/lib/components/pr-badge.tsx Updates PR badge sizing and alignment, with one small visual consistency issue in the inline PR number styling.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/emdash-desktop/src/renderer/lib/components/pr-badge.tsx:32-34
**PR Number Typography Diverges**

The default badge now renders the PR number with plain text, while the popover content and other PR rows still use `PrNumberBadge` with monospace text and wider tracking. Opening a PR badge shows the same number in two different styles, so the trigger no longer matches the rest of the PR-number UI.

```suggestion
            <span className="shrink-0 font-mono text-xs leading-none tracking-wide text-foreground-muted">
              #{getPrNumber(pr) ?? 0}
            </span>
```

Reviews (1): Last reviewed commit: "fix(tasks): align PR badge text" | Re-trigger Greptile

Comment thread apps/emdash-desktop/src/renderer/lib/components/pr-badge.tsx Outdated
@arnestrickmann arnestrickmann merged commit 971a0ef into main Jul 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants