Skip to content

feat(cli): allow prebuild images for langgraph deploy#8100

Open
hari-dhanushkodi wants to merge 5 commits into
mainfrom
hari/prebuilt
Open

feat(cli): allow prebuild images for langgraph deploy#8100
hari-dhanushkodi wants to merge 5 commits into
mainfrom
hari/prebuilt

Conversation

@hari-dhanushkodi

@hari-dhanushkodi hari-dhanushkodi commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Fixes #

adds a --image flag to langgraph deploy, allows a user to langgraph build a custom image and then deploy this specific image with langgraph deploy.

@hari-dhanushkodi hari-dhanushkodi marked this pull request as ready for review June 16, 2026 17:02

@open-swe open-swe Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Open SWE Review: No issues found

Open SWE reviewed this PR and found no potential bugs to report.

Open in WebView Open SWE trace

@phvash Asamu David (phvash) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Non-blocking, but two ux improvement suggestions"

  1. we should add existence check for the image, and
  2. We should also confirm the image's platform is linux/amd64 to avoid any gotchas during deployment.

hari-dhanushkodi and others added 2 commits June 16, 2026 21:56
Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>

@open-swe open-swe Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open SWE Review found 1 potential issue.

Open in WebView Open SWE trace

Comment on lines +384 to +388
except click.exceptions.Exit:
raise click.ClickException(
f"Docker image '{image}' was not found locally. Build or pull the image "
"before deploying with --image."
) from None

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Missing Docker crashes image validation

With --image, _resolve_build_mode(..., force_local=True) skips the existing can_build_locally() preflight, so this helper is the first place that invokes Docker. If the Docker binary is not installed, asyncio.create_subprocess_exec("docker", ...) raises FileNotFoundError (and the subprocess helper can surface that instead of click.exceptions.Exit), which is not caught here. That makes langgraph deploy --image ... crash with a traceback on machines without Docker instead of returning the actionable Docker-required error that the normal local-build path provides. Please catch the missing-binary case here or keep the Docker availability preflight for --image.

(Refers to lines 384-388)


Your feedback helps Open SWE learn. React with 👍 or 👎 to tell us if this review comment was useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants