-
Notifications
You must be signed in to change notification settings - Fork 5.9k
feat(cli): allow prebuild images for langgraph deploy #8100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hari-dhanushkodi
wants to merge
5
commits into
main
Choose a base branch
from
hari/prebuilt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+157
−45
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fd502ad
feat: add prebuilt image for langgraph deploy
hari-dhanushkodi fd12a2c
update help text
hari-dhanushkodi 796cb49
fix help text again
hari-dhanushkodi 2e0af6d
fix: validate prebuilt deploy image
hari-dhanushkodi f2fa706
chore: merge main into prebuilt image PR
hari-dhanushkodi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Missing Docker crashes image validation
With
--image,_resolve_build_mode(..., force_local=True)skips the existingcan_build_locally()preflight, so this helper is the first place that invokes Docker. If the Docker binary is not installed,asyncio.create_subprocess_exec("docker", ...)raisesFileNotFoundError(and the subprocess helper can surface that instead ofclick.exceptions.Exit), which is not caught here. That makeslanggraph deploy --image ...crash with a traceback on machines without Docker instead of returning the actionable Docker-required error that the normal local-build path provides. Please catch the missing-binary case here or keep the Docker availability preflight for--image.(Refers to lines 384-388)
Your feedback helps Open SWE learn. React with 👍 or 👎 to tell us if this review comment was useful.