test(langgraph): cover JSON overwrite sentinel replay#8126
test(langgraph): cover JSON overwrite sentinel replay#8126Sydney Runkle (sydney-runkle) wants to merge 1 commit into
Conversation
|
Closing this because the regression belongs in langgraph-api, not langgraph. The issue is API JSON serialization of Overwrite to the reserved overwrite sentinel. |
![open-swe[bot]](https://avatars.githubusercontent.com/in/1395372?s=60&v=4){kind=small}
| first_saved = saver.get_tuple(config) | ||
| assert first_saved is not None | ||
| snapshot = first_saved.checkpoint["channel_values"].get("items") | ||
| assert isinstance(snapshot, _DeltaSnapshot) |
There was a problem hiding this comment.
🟠 New regression test fails immediately
The test added by this PR fails on the current head: running uv run --directory /langgraph/libs/langgraph pytest /langgraph/libs/langgraph/tests/test_channels.py::test_delta_channel_api_json_overwrite_sentinel_snapshots_and_replays -q reaches this assertion with snapshot is None. With snapshot_frequency=1000, the current checkpoint code does not write an _DeltaSnapshot after the first overwrite update, so this PR would make the test suite fail until the implementation change it depends on is included or the test is marked/structured accordingly.
(Refers to line 437)
Your feedback helps Open SWE learn. React with 👍 or 👎 to tell us if this review comment was useful.
1 participant
Refs #8125
Depends on #8125
Adds regression coverage for API-style JSON
Overwritesentinel updates onDeltaChannel, verifying the streamed update shape, snapshot boundary, and later checkpoint replay.Not run; this test is expected to pass once #8125 lands.