-
Notifications
You must be signed in to change notification settings - Fork 5.9k
test(langgraph): cover JSON overwrite sentinel replay #8126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+44
−0
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 New regression test fails immediately
The test added by this PR fails on the current head: running
uv run --directory /langgraph/libs/langgraph pytest /langgraph/libs/langgraph/tests/test_channels.py::test_delta_channel_api_json_overwrite_sentinel_snapshots_and_replays -qreaches this assertion withsnapshot is None. Withsnapshot_frequency=1000, the current checkpoint code does not write an_DeltaSnapshotafter the first overwrite update, so this PR would make the test suite fail until the implementation change it depends on is included or the test is marked/structured accordingly.(Refers to line 437)
Your feedback helps Open SWE learn. React with 👍 or 👎 to tell us if this review comment was useful.