Fix: handle upload stream with unknown size#1481
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn ChangesMultipart Upload Part Numbering and Empty-Parts Fallback
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Please add unit/functional test @Hydrog3n |
|
@prakashsvmx Yep I was on it sorry 🙂 |
prakashsvmx
left a comment
There was a problem hiding this comment.
Please test with minio, aws s3 on both and present results
| for await (const chunk of chunkier) { | ||
| const md5 = crypto.createHash('md5').update(chunk).digest() | ||
|
|
||
| partNumber++ |
There was a problem hiding this comment.
This needs to be compatibility tested for partNumber
Hello, first thank you for the lib 🙏🏼
I arrived on a case where I have a stream from a DB who are converted to csv through pipe and uploading to S3.
But in certain case I have no data and I got this error since I update from 8.0.5 => 8.0.7
I'm open to improvement.
Summary by CodeRabbit
Bug Fixes