Skip to content

Fix: handle upload stream with unknown size #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hydrog3n wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: handle upload stream with unknown size #1481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/internal/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1800,22 +1800,20 @@ export class TypedClient {
chunkier.on('end', resolve).on('error', reject)
}),
(async () => {
let partNumber = 1
let partNumber = 0

for await (const chunk of chunkier) {
const md5 = crypto.createHash('md5').update(chunk).digest()

partNumber++

@prakashsvmx prakashsvmx Jun 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be compatibility tested for partNumber

const oldPart = oldParts[partNumber]
if (oldPart) {
if (oldPart.etag === md5.toString('hex')) {
eTags.push({ part: partNumber, etag: oldPart.etag })
partNumber++
continue
}
}

partNumber++

// now start to upload missing part
const options: RequestOption = {
method: 'PUT',
Expand All @@ -1840,6 +1838,11 @@ export class TypedClient {
eTags.push({ part: partNumber, etag })
}

if (eTags.length === 0) {
await this.abortMultipartUpload(bucketName, objectName, uploadId)
return await this.uploadBuffer(bucketName, objectName, headers, Buffer.from(''))
}

return await this.completeMultipartUpload(bucketName, objectName, uploadId, eTags)
})(),
])
Expand Down
Loading