[Feat] Add Ubuntu 26 support#1081
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds Ubuntu 26 support by introducing a new ChangesUbuntu 26 OS Support
Mise Installation GPG Keyring Security
Development Guidelines
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Add UBUNTU26 enum case with version 26.04 - Add ubuntu_26 to core operating_systems list - Add static image entries for Linode and Hetzner (which use the static images map). AWS, DigitalOcean, and Vultr resolve images dynamically via the provider API using getVersion(), so they need no static entry.
saeedvaziry
force-pushed
the
add-ubuntu-26-suppor
branch
from
b13a952 to
ae9428c
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CLAUDE.md`:
- Line 120: The documentation at line 120 in CLAUDE.md is incomplete and does
not match the actual CI validation rules defined in the PR title workflow.
Update the line to specify the complete requirement that PR titles must start
with either `[Feat]` or `[Fix]`, followed by a space and then a description.
This will align the documentation with the actual GitHub Actions CI enforcement
and provide clearer guidance to contributors about the exact format expected.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 31ff7762-d5f9-4527-b104-2899af01b5ad
📒 Files selected for processing (1)
CLAUDE.md
|
|
||
| - Use `gh` CLI for issues/PRs. | ||
| - Don't change dependencies or create new base folders without approval. | ||
| - PR titles must be prefixed with `[Feat]` or `[Fix]` |
There was a problem hiding this comment.
Incomplete documentation: PR title rule omits required space and description.
Line 120 documents only the prefix requirement ([Feat] or [Fix]), but the GitHub Actions CI validation at .github/workflows/pr-title.yml actually enforces a space and description after the prefix. The workflow's error message is more explicit: "PR titles must start with [Feat] or [Fix], followed by a space and a description."
Update line 120 to match the CI enforcement and provide clearer guidance to contributors.
📝 Proposed fix to improve documentation completeness
- PR titles must be prefixed with `[Feat]` or `[Fix]`
+ PR titles must start with `[Feat]` or `[Fix]`, followed by a space and a description (e.g. `[Feat] Add per-site PHP runtime settings`)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - PR titles must be prefixed with `[Feat]` or `[Fix]` | |
| - PR titles must start with `[Feat]` or `[Fix]`, followed by a space and a description (e.g. `[Feat] Add per-site PHP runtime settings`) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CLAUDE.md` at line 120, The documentation at line 120 in CLAUDE.md is
incomplete and does not match the actual CI validation rules defined in the PR
title workflow. Update the line to specify the complete requirement that PR
titles must start with either `[Feat]` or `[Fix]`, followed by a space and then
a description. This will align the documentation with the actual GitHub Actions
CI enforcement and provide clearer guidance to contributors about the exact
format expected.
Ubuntu 26 (resolute) ships a newer apt that rejects ASCII-armored keyrings referenced via signed-by=, failing with 'unsupported filetype' and NO_PUBKEY, which broke the install-dependencies step. - Pipe the mise GPG key through 'gpg --dearmor' into a binary .gpg keyring instead of writing the armored .pub directly - Install gnupg so 'gpg --dearmor' is available on minimal images - Detect architecture with dpkg --print-architecture in ensure-installed instead of hardcoding arch=amd64 Applies to both the OS install-dependencies and mise ensure-installed scripts. Backward compatible with Ubuntu 20/22/24.
1 participant
Not all providers support ubuntu 26 yet
Summary by CodeRabbit
[Feat]or[Fix]prefixes