Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,3 +117,4 @@ Vito has a specific architecture. Match these patterns exactly:

- Use `gh` CLI for issues/PRs.
- Don't change dependencies or create new base folders without approval.
- PR titles must be prefixed with `[Feat]` or `[Fix]`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Incomplete documentation: PR title rule omits required space and description.

Line 120 documents only the prefix requirement ([Feat] or [Fix]), but the GitHub Actions CI validation at .github/workflows/pr-title.yml actually enforces a space and description after the prefix. The workflow's error message is more explicit: "PR titles must start with [Feat] or [Fix], followed by a space and a description."

Update line 120 to match the CI enforcement and provide clearer guidance to contributors.

📝 Proposed fix to improve documentation completeness
- PR titles must be prefixed with `[Feat]` or `[Fix]`
+ PR titles must start with `[Feat]` or `[Fix]`, followed by a space and a description (e.g. `[Feat] Add per-site PHP runtime settings`)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- PR titles must be prefixed with `[Feat]` or `[Fix]`
- PR titles must start with `[Feat]` or `[Fix]`, followed by a space and a description (e.g. `[Feat] Add per-site PHP runtime settings`)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CLAUDE.md` at line 120, The documentation at line 120 in CLAUDE.md is
incomplete and does not match the actual CI validation rules defined in the PR
title workflow. Update the line to specify the complete requirement that PR
titles must start with either `[Feat]` or `[Fix]`, followed by a space and then
a description. This will align the documentation with the actual GitHub Actions
CI enforcement and provide clearer guidance to contributors about the exact
format expected.

2 changes: 2 additions & 0 deletions app/Enums/OperatingSystem.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ enum OperatingSystem: string implements VitoEnum
case UBUNTU20 = 'ubuntu_20';
case UBUNTU22 = 'ubuntu_22';
case UBUNTU24 = 'ubuntu_24';
case UBUNTU26 = 'ubuntu_26';

public function getColor(): string
{
Expand All @@ -28,6 +29,7 @@ public function getVersion(): string
self::UBUNTU20 => '20.04',
self::UBUNTU22 => '22.04',
self::UBUNTU24 => '24.04',
self::UBUNTU26 => '26.04',
};
}
}
1 change: 1 addition & 0 deletions config/core.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
OperatingSystem::UBUNTU20->value,
OperatingSystem::UBUNTU22->value,
OperatingSystem::UBUNTU24->value,
OperatingSystem::UBUNTU26->value,
],

/*
Expand Down
2 changes: 2 additions & 0 deletions config/serverproviders.php
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,7 @@
'ubuntu_20' => 'linode/ubuntu20.04',
'ubuntu_22' => 'linode/ubuntu22.04',
'ubuntu_24' => 'linode/ubuntu24.04',
'ubuntu_26' => 'linode/ubuntu26.04',
],
],
'digitalocean' => [
Expand Down Expand Up @@ -945,6 +946,7 @@
'ubuntu_20' => 'ubuntu-20.04',
'ubuntu_22' => 'ubuntu-22.04',
'ubuntu_24' => 'ubuntu-24.04',
'ubuntu_26' => 'ubuntu-26.04',
],
],
];
6 changes: 3 additions & 3 deletions resources/views/ssh/mise/ensure-installed.blade.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
exit 0
fi

sudo apt update -y && sudo apt install -y curl
sudo apt update -y && sudo apt install -y curl gnupg
sudo install -dm 755 /etc/apt/keyrings
curl -fsSL https://mise.jdx.dev/gpg-key.pub | sudo tee /etc/apt/keyrings/mise-archive-keyring.pub 1> /dev/null
echo "deb [signed-by=/etc/apt/keyrings/mise-archive-keyring.pub arch=amd64] https://mise.jdx.dev/deb stable main" | sudo tee /etc/apt/sources.list.d/mise.list
curl -fsSL https://mise.jdx.dev/gpg-key.pub | sudo gpg --dearmor -o /etc/apt/keyrings/mise-archive-keyring.gpg
echo "deb [signed-by=/etc/apt/keyrings/mise-archive-keyring.gpg arch=$(dpkg --print-architecture)] https://mise.jdx.dev/deb stable main" | sudo tee /etc/apt/sources.list.d/mise.list
sudo apt update
sudo apt install -y mise

Expand Down
6 changes: 3 additions & 3 deletions resources/views/ssh/os/install-dependencies.blade.php
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
sudo DEBIAN_FRONTEND=noninteractive NEEDRESTART_MODE=a apt-get -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" install -y software-properties-common curl zip unzip git gcc openssl ufw cron
sudo DEBIAN_FRONTEND=noninteractive NEEDRESTART_MODE=a apt-get -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" install -y software-properties-common curl zip unzip git gcc openssl ufw cron gnupg
git config --global user.email "{{ $email }}"
git config --global user.name "{{ $name }}"

# Install Mise
sudo install -dm 755 /etc/apt/keyrings
curl -fsSL https://mise.jdx.dev/gpg-key.pub | sudo tee /etc/apt/keyrings/mise-archive-keyring.pub 1> /dev/null
echo "deb [signed-by=/etc/apt/keyrings/mise-archive-keyring.pub arch=$(dpkg --print-architecture)] https://mise.jdx.dev/deb stable main" | sudo tee /etc/apt/sources.list.d/mise.list
curl -fsSL https://mise.jdx.dev/gpg-key.pub | sudo gpg --dearmor -o /etc/apt/keyrings/mise-archive-keyring.gpg
echo "deb [signed-by=/etc/apt/keyrings/mise-archive-keyring.gpg arch=$(dpkg --print-architecture)] https://mise.jdx.dev/deb stable main" | sudo tee /etc/apt/sources.list.d/mise.list
sudo DEBIAN_FRONTEND=noninteractive NEEDRESTART_MODE=a apt-get update
sudo DEBIAN_FRONTEND=noninteractive NEEDRESTART_MODE=a apt-get -o Dpkg::Options::="--force-confdef" -o Dpkg::Options::="--force-confold" install -y mise
Loading